hw/i386/vmport: Assert vmport initialized before registering commands
authorLiran Alon <liran.alon@oracle.com>
Thu, 12 Mar 2020 16:54:31 +0000 (18:54 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 10 Jun 2020 16:09:54 +0000 (12:09 -0400)
commit23accdf162dcccb9fec9585a64ad01a87b13da5c
tree785921c36fa0e974145b52279f752e1e1b6648f8
parentd6048bfd12e24a0980ba2040cfaa2b101df3fa16
hw/i386/vmport: Assert vmport initialized before registering commands

vmport_register() is also called from other modules such as vmmouse.
Therefore, these modules rely that vmport is realized before those call
sites. If this is violated, vmport_register() will NULL-deref.

To make such issues easier to debug, assert in vmport_register() that
vmport is already realized.

Reviewed-by: Nikita Leshenko <nikita.leshchenko@oracle.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
Message-Id: <20200312165431.82118-17-liran.alon@oracle.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/i386/vmport.c