drm/i915/edp: don't write to DP_LINK_BW_SET when using rate select
authorJani Nikula <jani.nikula@intel.com>
Tue, 5 Dec 2023 18:05:51 +0000 (20:05 +0200)
committerJani Nikula <jani.nikula@intel.com>
Mon, 11 Dec 2023 09:49:09 +0000 (11:49 +0200)
commit23b392b94acb0499f69706c5808c099f590ebcf4
tree55f059d0c5a36c32caa744b22c0b414ab6d1c34d
parent362a8dba85ebedbf6939dad78bc6de398a2ef4e7
drm/i915/edp: don't write to DP_LINK_BW_SET when using rate select

The eDP 1.5 spec adds a clarification for eDP 1.4x:

> For eDP v1.4x, if the Source device chooses the Main-Link rate by way
> of DPCD 00100h, the Sink device shall ignore DPCD 00115h[2:0].

We write 0 to DP_LINK_BW_SET (DPCD 100h) even when using
DP_LINK_RATE_SET (DPCD 114h). Stop doing that, as it can cause the panel
to ignore the rate set method.

Moreover, 0 is a reserved value for DP_LINK_BW_SET, and should not be
used.

v2: Improve the comments (Ville)

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9081
Tested-by: Animesh Manna <animesh.manna@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231205180551.2476228-1-jani.nikula@intel.com
drivers/gpu/drm/i915/display/intel_dp_link_training.c