projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 0fdf10e) | patch
platform/x86: think-lmi: Move kfree(setting->possible_values) to tlmi_attr_setting_re...
authorHans de Goede <hdegoede@redhat.com>
Mon, 28 Jun 2021 09:36:00 +0000 (11:36 +0200)
committerHans de Goede <hdegoede@redhat.com>
Mon, 28 Jun 2021 09:52:42 +0000 (11:52 +0200)
commit23dcd7497c227a16acdda5e44f141fdc1e660f94
tree58ad07eab5208e6fd6fcc58dbb5db35bf8a569bftree | snapshot
parent0fdf10e5fc964c315cf131a2eaab9cc531a9f40fcommit | diff
platform/x86: think-lmi: Move kfree(setting->possible_values) to tlmi_attr_setting_release()

We must not free the possible_values string before we have called
sysfs_remove_group(kobj, &tlmi_attr_group) otherwise there is a race
where a sysfs read of possible_values could reference the free-ed
memory.

Move the kfree(setting->possible_values) together with the free of the
actual tlmi_attr_setting struct to avoid this race.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/think-lmi.c diff | blob | history
ep93xx device tree rework repo: git://git.maquefel.me/linux.git