nfsd: perform all find_openstateowner_str calls in the one place.
authorNeilBrown <neilb@suse.de>
Mon, 8 Apr 2024 02:09:15 +0000 (12:09 +1000)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 6 May 2024 13:07:15 +0000 (09:07 -0400)
commit23df17788c6212809848f836b10c4f85b16843a5
tree9a0e8c6bf2c81acfdfd3d13d78cd84248b4eecde
parentdd5a440a31fae6e459c0d6271dddd62825505361
nfsd: perform all find_openstateowner_str calls in the one place.

Currently find_openstateowner_str look ups are done both in
nfsd4_process_open1() and alloc_init_open_stateowner() - the latter
possibly being a surprise based on its name.

It would be easier to follow, and more conformant to common patterns, if
the lookup was all in the one place.

So replace alloc_init_open_stateowner() with
find_or_alloc_open_stateowner() and use the latter in
nfsd4_process_open1() without any calls to find_openstateowner_str().

This means all finds are find_openstateowner_str_locked() and
find_openstateowner_str() is no longer needed.  So discard
find_openstateowner_str() and rename find_openstateowner_str_locked() to
find_openstateowner_str().

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4state.c