leds: ledtrig-tty: Free allocated ttyname buffer on deactivate
authorFlorian Eckert <fe@dev.tdt.de>
Mon, 27 Nov 2023 08:16:21 +0000 (09:16 +0100)
committerLee Jones <lee@kernel.org>
Wed, 13 Dec 2023 11:28:43 +0000 (11:28 +0000)
commit25054b232681c286fca9c678854f56494d1352cc
tree7a4b3b074432ff221c35dea0a21f694aacc87d02
parent736214b4b02adf8734206599e36e2081d47554a2
leds: ledtrig-tty: Free allocated ttyname buffer on deactivate

The ttyname buffer for the ledtrig_tty_data struct is allocated in the
sysfs ttyname_store() function. This buffer must be released on trigger
deactivation. This was missing and is thus a memory leak.

While we are at it, the TTY handler in the ledtrig_tty_data struct should
also be returned in case of the trigger deactivation call.

Cc: stable@vger.kernel.org
Fixes: fd4a641ac88f ("leds: trigger: implement a tty trigger")
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20231127081621.774866-1-fe@dev.tdt.de
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/trigger/ledtrig-tty.c