clk: hisilicon: Use devm_kcalloc() instead of devm_kzalloc()
authorErick Archer <erick.archer@gmx.com>
Sun, 21 Jan 2024 14:29:46 +0000 (15:29 +0100)
committerStephen Boyd <sboyd@kernel.org>
Thu, 22 Feb 2024 04:27:19 +0000 (20:27 -0800)
commit252c31a90e04dee4d828282ca364daf05eb62000
tree152f32a53261725000204bd3846aa360bf728ab2
parent64c6a38136b74a2f18c42199830975edd9fbc379
clk: hisilicon: Use devm_kcalloc() instead of devm_kzalloc()

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific devm_kcalloc() function instead of the
argument size * count in the devm_kzalloc() function.

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
Link: https://lore.kernel.org/r/20240121142946.2796-1-erick.archer@gmx.com
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/hisilicon/clk-hi3559a.c