NFS: NFSv2/v3 clients should never be setting NFS_CAP_XATTR
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 22 Feb 2022 23:20:38 +0000 (18:20 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:22:52 +0000 (14:22 +0200)
commit253a9533941ef89156955ea9f24e09e182450ba9
tree98af5239e9d2e65fdb61c50dfe805689c6b05cc3
parent518a7d6be1ed5ce056544fd03d8487fcf704768b
NFS: NFSv2/v3 clients should never be setting NFS_CAP_XATTR

commit b622ffe1d9ecbac71f0cddb52ff0831efdf8fb83 upstream.

Ensure that we always initialise the 'xattr_support' field in struct
nfs_fsinfo, so that nfs_server_set_fsinfo() doesn't declare our NFSv2/v3
client to be capable of supporting the NFSv4.2 xattr protocol by setting
the NFS_CAP_XATTR capability.

This configuration can cause nfs_do_access() to set access mode bits
that are unsupported by the NFSv3 ACCESS call, which may confuse
spec-compliant servers.

Reported-by: Olga Kornievskaia <kolga@netapp.com>
Fixes: b78ef845c35d ("NFSv4.2: query the server for extended attribute support")
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/nfs3xdr.c
fs/nfs/proc.c