ksmbd: fix posix_acls and acls dereferencing possible ERR_PTR()
authorNamjae Jeon <linkinjeon@kernel.org>
Tue, 30 May 2023 12:42:34 +0000 (21:42 +0900)
committerSteve French <stfrench@microsoft.com>
Fri, 2 Jun 2023 17:30:57 +0000 (12:30 -0500)
commit25933573ef48f3586f559c2cac6c436c62dcf63f
tree26b7227c239f12d29a5432b0d4a779a7ec32dd45
parentfc6c6a3c324c1b3e93a03d0cfa3749c781f23de0
ksmbd: fix posix_acls and acls dereferencing possible ERR_PTR()

Dan reported the following error message:

fs/smb/server/smbacl.c:1296 smb_check_perm_dacl()
    error: 'posix_acls' dereferencing possible ERR_PTR()
fs/smb/server/vfs.c:1323 ksmbd_vfs_make_xattr_posix_acl()
    error: 'posix_acls' dereferencing possible ERR_PTR()
fs/smb/server/vfs.c:1830 ksmbd_vfs_inherit_posix_acl()
    error: 'acls' dereferencing possible ERR_PTR()

__get_acl() returns a mix of error pointers and NULL. This change it
with IS_ERR_OR_NULL().

Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
Cc: stable@vger.kernel.org
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smbacl.c
fs/smb/server/vfs.c