virtio-net: Store failover primary opts pointer locally
authorKevin Wolf <kwolf@redhat.com>
Fri, 8 Oct 2021 13:34:39 +0000 (15:34 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 15 Oct 2021 14:11:22 +0000 (16:11 +0200)
commit259a10dbcb4f36a3489fb52f9f7a654761589448
tree62e5d2bd1716b6d5c6ca4ff9b88f3c3d535893c1
parent7d61808206cc651ae42024ab6def827afa2f807b
virtio-net: Store failover primary opts pointer locally

Instead of accessing the global QemuOptsList, which really belong to the
command line parser and shouldn't be accessed from devices, store a
pointer to the QemuOpts in a new VirtIONet field.

This is not the final state, but just an intermediate step to get rid of
QemuOpts in devices. It will later be replaced with an options QDict.

Before this patch, two "primary" devices could be hidden for the same
standby device, but only one of them would actually be enabled and the
other one would be kept hidden forever, so this doesn't make sense.
After this patch, configuring a second primary device is an error.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20211008133442.141332-13-kwolf@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/net/virtio-net.c
include/hw/virtio/virtio-net.h