ath11k: Fix some resource leaks in error path in 'ath11k_thermal_register()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Wed, 13 May 2020 20:14:54 +0000 (22:14 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 19 May 2020 06:54:53 +0000 (09:54 +0300)
commit25ca180ad380a0c7286442a922e7fbcc6a9f6083
tree55d9739435ae1e3a81600afe9d819cf2dfa65307
parentec431188b4197aaccfbc6e6ece4fb88f79723635
ath11k: Fix some resource leaks in error path in 'ath11k_thermal_register()'

If 'thermal_cooling_device_register()' fails, we must undo what has been
allocated so far. So we must go to 'err_thermal_destroy' instead of
returning directly

In case of error in 'ath11k_thermal_register()', the previous
'thermal_cooling_device_register()' call must also be undone. Move the
'ar->thermal.cdev = cdev' a few lines above in order for this to be done
in 'ath11k_thermal_unregister()' which is called in the error handling
path.

Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200513201454.258111-1-christophe.jaillet@wanadoo.fr
drivers/net/wireless/ath/ath11k/thermal.c