ui/cocoa.m: Remove unnecessary NSAutoreleasePools
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 24 Feb 2022 10:13:30 +0000 (10:13 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Wed, 2 Mar 2022 19:27:37 +0000 (19:27 +0000)
commit268c11984e67867c22f53beb3c7f8b98900d66b2
tree375cd35f955b77dfc20bf67c6d0c2a895f7a8f33
parent8d65dee2c42abf323a0494200f2086ddf05444c2
ui/cocoa.m: Remove unnecessary NSAutoreleasePools

In commit 6e657e64cdc478 in 2013 we added some autorelease pools to
deal with complaints from macOS when we made calls into Cocoa from
threads that didn't have automatically created autorelease pools.
Later on, macOS got stricter about forbidding cross-thread Cocoa
calls, and in commit 5588840ff77800e839d8 we restructured the code to
avoid them.  This left the autorelease pool creation in several
functions without any purpose; delete it.

We still need the pool in cocoa_refresh() for the clipboard related
code which is called directly there.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Tested-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-id: 20220224101330.967429-3-peter.maydell@linaro.org
ui/cocoa.m