wifi: mac80211: rename ieee80211_tx_status() to ieee80211_tx_status_skb()
authorKalle Valo <quic_kvalo@quicinc.com>
Thu, 12 Oct 2023 11:42:28 +0000 (14:42 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 23 Oct 2023 10:26:51 +0000 (12:26 +0200)
commit2703bc8513996e848b5aefa2deb1ff3baae5d79b
tree2a4f60c763cbcc1fb19da83c25983bf69ea7e6ad
parentc3e5f5f60ef2da3976c77a4f389aeecc5cf31f6b
wifi: mac80211: rename ieee80211_tx_status() to ieee80211_tx_status_skb()

make htmldocs warns:

Documentation/driver-api/80211/mac80211:109: ./include/net/mac80211.h:5170: WARNING: Duplicate C declaration, also defined at mac80211:1117.
Declaration is '.. c:function:: void ieee80211_tx_status (struct ieee80211_hw *hw, struct sk_buff *skb)'.

This is because there's a function named ieee80211_tx_status() and a struct named
ieee80211_tx_status. This has been discussed previously but no solution found:

https://lore.kernel.org/all/20220521114629.6ee9fc06@coco.lan/

There's also a bug open for three years with no solution in sight:

https://github.com/sphinx-doc/sphinx/pull/8313

So I guess we have no other solution than to a workaround this in the code,
for example to rename the function to ieee80211_tx_status_skb() to avoid the
name conflict. I got the idea for the name from ieee80211_tx_status_noskb() in
which the skb is not provided as an argument, instead with
ieee80211_tx_status_skb() the skb is provided.

Compile tested only.

Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20231012114229.2931808-2-kvalo@kernel.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
16 files changed:
Documentation/driver-api/80211/mac80211.rst
drivers/net/wireless/ath/ath12k/dp_tx.c
drivers/net/wireless/ath/ath5k/base.c
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
drivers/net/wireless/ath/ath9k/xmit.c
drivers/net/wireless/broadcom/b43/dma.c
drivers/net/wireless/broadcom/b43/pio.c
drivers/net/wireless/intel/iwlwifi/dvm/tx.c
drivers/net/wireless/intel/iwlwifi/mvm/tx.c
drivers/net/wireless/mediatek/mt7601u/tx.c
drivers/net/wireless/ralink/rt2x00/rt2x00dev.c
drivers/net/wireless/st/cw1200/txrx.c
drivers/net/wireless/ti/wl1251/tx.c
include/net/mac80211.h
net/mac80211/main.c
net/mac80211/status.c