bpf: Build type-punning BPF selftests with -fno-strict-aliasing
authorJose E. Marchesi <jose.marchesi@oracle.com>
Tue, 30 Jan 2024 11:03:43 +0000 (12:03 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Tue, 30 Jan 2024 15:08:18 +0000 (16:08 +0100)
commit27a90b14b93d3b2e1efd10764e456af7e2a42991
treed830754421a89bf6005406d6e13f276796662a78
parent6668e818f960b0f32110a9efa7c97351a5771b35
bpf: Build type-punning BPF selftests with -fno-strict-aliasing

A few BPF selftests perform type punning and they may break strict
aliasing rules, which are exploited by both GCC and clang by default
while optimizing.  This can lead to broken compiled programs.

This patch disables strict aliasing for these particular tests, by
mean of the -fno-strict-aliasing command line option.  This will make
sure these tests are optimized properly even if some strict aliasing
rule gets violated.

After this patch, GCC is able to build all the selftests without
warning about potential strict aliasing issue.

bpf@vger discussion on strict aliasing and BPF selftests:
https://lore.kernel.org/bpf/bae1205a-b6e5-4e46-8e20-520d7c327f7a@linux.dev/T/#t

Tested in bpf-next master.
No regressions.

Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/bae1205a-b6e5-4e46-8e20-520d7c327f7a@linux.dev
Link: https://lore.kernel.org/bpf/20240130110343.11217-1-jose.marchesi@oracle.com
tools/testing/selftests/bpf/Makefile