ceph: remove unnecessary check for NULL in parse_longname()
authorLuís Henriques <lhenriques@suse.de>
Fri, 8 Sep 2023 11:20:20 +0000 (12:20 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 18 Sep 2023 10:04:50 +0000 (12:04 +0200)
commit2816a09678f50fc6a69e742e90cb1fd7a9f1f9ff
treea6ee8c15c90a966b9f6c5e7d0a5199cc5880e8d2
parentce9ecca0238b140b88f43859b211c9fdfd8e5b70
ceph: remove unnecessary check for NULL in parse_longname()

Function ceph_get_inode() never returns NULL; instead it returns an
ERR_PTR() if something fails.  Thus, the check for NULL in parse_longname()
is useless and can be dropped.  Instead, move there the debug code that
does the error checking so that it's only executed if ceph_get_inode() is
called.

Fixes: dd66df0053ef ("ceph: add support for encrypted snapshot names")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Luís Henriques <lhenriques@suse.de>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/crypto.c