staging: rtl8192u: Fix return type of ieee80211_xmit
authorNathan Huckleberry <nhuck@google.com>
Wed, 14 Sep 2022 21:07:50 +0000 (14:07 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 24 Sep 2022 11:05:33 +0000 (13:05 +0200)
commit2851349ac351010a2649e0ff86a1e3d68fe5d683
tree1a93062bda8ee588cc5ff8983e38d22341c11d92
parent2a2db520e3ca5aafba7c211abfd397666c9b5f9d
staging: rtl8192u: Fix return type of ieee80211_xmit

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of ieee80211_xmit should be changed from int to
netdev_tx_t.

Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Reported-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Link: https://lore.kernel.org/r/20220914210750.423048-1-nhuck@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/ieee80211.h
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c