selftests/bpf: Use log_err in open_netns/close_netns
authorGeliang Tang <tanggeliang@kylinos.cn>
Tue, 23 Apr 2024 10:35:28 +0000 (18:35 +0800)
committerMartin KaFai Lau <martin.lau@kernel.org>
Wed, 24 Apr 2024 20:12:28 +0000 (13:12 -0700)
commit285cffbaa8e6056c2595e07e3a320e55c71870ad
tree22eb34fa81d0539efda298351b62c08b15845dfb
parent151f7442436658ee84076681d8f52e987fe147ea
selftests/bpf: Use log_err in open_netns/close_netns

ASSERT helpers defined in test_progs.h shouldn't be used in public
functions like open_netns() and close_netns(). Since they depend on
test__fail() which defined in test_progs.c. Public functions may be
used not only in test_progs.c, but in other tests like test_sock_addr.c
in the next commit.

This patch uses log_err() to replace ASSERT helpers in open_netns()
and close_netns() in network_helpers.c to decouple dependencies, then
uses ASSERT_OK_PTR() to check the return values of all open_netns().

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Link: https://lore.kernel.org/r/d1dad22b2ff4909af3f8bfd0667d046e235303cb.1713868264.git.tanggeliang@kylinos.cn
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
tools/testing/selftests/bpf/network_helpers.c
tools/testing/selftests/bpf/prog_tests/empty_skb.c
tools/testing/selftests/bpf/prog_tests/ip_check_defrag.c
tools/testing/selftests/bpf/prog_tests/tc_redirect.c
tools/testing/selftests/bpf/prog_tests/test_tunnel.c
tools/testing/selftests/bpf/prog_tests/xdp_metadata.c