HID: magicmouse: Fix an error handling path in magicmouse_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 28 Dec 2021 21:09:17 +0000 (22:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:05:08 +0000 (11:05 +0100)
commit2884aac078745798419f74cfc13025558e718541
tree2042ea6a0d09ef76f96d0e056accf6410dc05dff
parent00e3d58f50a875343124bcf5a9637520a492b0d1
HID: magicmouse: Fix an error handling path in magicmouse_probe()

commit 33812fc7c8d77a43b7e2bf36a0d5a57c277a4b0c upstream.

If the timer introduced by the commit below is started, then it must be
deleted in the error handling of the probe. Otherwise it would trigger
once the driver is no more.

Fixes: 0b91b4e4dae6 ("HID: magicmouse: Report battery level over USB")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Tested-by: José Expósito <jose.exposito89@gmail.com>
Reported-by: <syzbot+a437546ec71b04dfb5ac@syzkaller.appspotmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-magicmouse.c