RDMA/usnic: Avoid overly large buffers on stack
authorArnd Bergmann <arnd@arndb.de>
Fri, 6 Sep 2019 15:57:17 +0000 (17:57 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Fri, 13 Sep 2019 19:55:55 +0000 (16:55 -0300)
commit2ac5a6d3a917755919d97c89f8aa74e4ed958557
treed90366ab71e24835c610b0effdd3862f29e0c5db
parentb97b218b302d7ccc82381d3c8254396804e7d819
RDMA/usnic: Avoid overly large buffers on stack

It's never a good idea to put a 1000-byte buffer on the kernel stack. The
compiler warns about this instance when usnic_ib_log_vf() gets inlined
into usnic_ib_pci_probe():

drivers/infiniband/hw/usnic/usnic_ib_main.c:543:12: error: stack frame size of 1044 bytes in function 'usnic_ib_pci_probe' [-Werror,-Wframe-larger-than=]

As this is only called for debugging purposes in the setup path, it's
trivial to convert to a dynamic allocation.

Link: https://lore.kernel.org/r/20190906155730.2750200-1-arnd@arndb.de
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/usnic/usnic_ib_main.c