projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f945c54) | patch
usb: usbip: vudc: Fix WARN_ON() usage pattern
authorKrzysztof Opasiak <k.opasiak@samsung.com>
Wed, 27 Apr 2016 18:00:26 +0000 (20:00 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Apr 2016 19:28:08 +0000 (12:28 -0700)
commit2bdf6ea51ce8dcd98f4f394d7203dbace01f5cbc
tree57ed98b5a30012dd4171427e5feed488f0820531tree | snapshot
parentf945c546656e4330665a69aa35ae6491025128fccommit | diff
usb: usbip: vudc: Fix WARN_ON() usage pattern

Fix WARN_ON() macro usage as suggested by Felipe.
Instead of using:
if (cond) {
   WARN_ON(1);
   do_stuff();
}

Use a better pattern with WARN_ON() placed in if condition:

if (WARN_ON(cond))
   do_stuff();

Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usbip/vudc_dev.c diff | blob | history
ep93xx device tree rework repo: git://git.maquefel.me/linux.git