xfs: fix CIL sparse lock context warnings
authorDave Chinner <dchinner@redhat.com>
Tue, 2 Apr 2024 21:28:28 +0000 (08:28 +1100)
committerChandan Babu R <chandanbabu@kernel.org>
Sat, 20 Apr 2024 14:53:59 +0000 (20:23 +0530)
commit2c03d9560ecebf2865b963e457ba89299c5f1966
treeb895b07fb592d70479f249ae257d0940783c3797
parent9cb5f15d88d4cbda3bac22769d9e4808bd6cf248
xfs: fix CIL sparse lock context warnings

Sparse reports:

fs/xfs/xfs_log_cil.c:1127:1: warning: context imbalance in 'xlog_cil_push_work' - different lock contexts for basic block
fs/xfs/xfs_log_cil.c:1380:1: warning: context imbalance in 'xlog_cil_push_background' - wrong count at exit
fs/xfs/xfs_log_cil.c:1623:9: warning: context imbalance in 'xlog_cil_commit' - unexpected unlock

xlog_cil_push_background() has a locking annotations for an rw_sem.
Sparse does not track lock contexts for rw_sems, so the
annotation generates false warnings. Remove the annotation.

xlog_wait_on_iclog() drops the log->l_ic_loglock. The function has a
sparse annotation, but the prototype in xfs_log_priv.h does not.
Hence the warning from xlog_cil_push_work() which calls
xlog_wait_on_iclog(). Add the missing annotation.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
fs/xfs/xfs_log_cil.c
fs/xfs/xfs_log_priv.h