bpf: task_group_seq_get_next: use __next_thread() rather than next_thread()
authorOleg Nesterov <oleg@redhat.com>
Tue, 14 Nov 2023 16:32:34 +0000 (17:32 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Sun, 19 Nov 2023 19:43:44 +0000 (11:43 -0800)
commit2d1618054f25e11c44d189dbff4a60342a4cfb4b
treef801475761d64aa6bdaed25a183a7cc23efbce55
parent16b3129e14bf2e7505512568b11c437c840a0c19
bpf: task_group_seq_get_next: use __next_thread() rather than next_thread()

Lockless use of next_thread() should be avoided, kernel/bpf/task_iter.c
is the last user and the usage is wrong.

task_group_seq_get_next() can return the group leader twice if it races
with mt-thread exec which changes the group->leader's pid.

Change the main loop to use __next_thread(), kill "next_tid == common->pid"
check.

__next_thread() can't loop forever, we can also change this code to retry
if next_tid == 0.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20231114163234.GA890@redhat.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/task_iter.c