scsi: elx: sli4: Remove code duplication
authorRajeshwar R Shinde <coolrrsh@gmail.com>
Thu, 17 Aug 2023 11:43:01 +0000 (17:13 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 21 Aug 2023 21:13:56 +0000 (17:13 -0400)
commit2d6f70fe175e342d29ee1103523551bb224981d4
tree6596853feb4b839f8d4aac99c0d86c5ae2c5ccc4
parent56a4d69a26c9bc77f4697692b6f7223e09f9de1a
scsi: elx: sli4: Remove code duplication

In the function sli_xmit_bls_rsp64_wqe(), the 'if' and 'else' conditions
evaluates the same expression and give the same output. Also, params->s_id
shall not be equal to U32_MAX. Remove the unused code.

This fixes coccinelle warning such as:
drivers/scsi/elx/libefc_sli/sli4.c:2320:2-4: WARNING: possible
condition with no effect (if == else)

Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
Link: https://lore.kernel.org/r/20230817114301.17601-1-coolrrsh@gmail.com
Reviewed-by: Ram Vegesna <ram.vegesna@broadcom.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/elx/libefc_sli/sli4.c