PCI: rockchip-ep: Remove wrong mask on subsys_vendor_id
authorRick Wertenbroek <rick.wertenbroek@gmail.com>
Wed, 3 Apr 2024 14:45:08 +0000 (16:45 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 15 May 2024 21:07:30 +0000 (16:07 -0500)
commit2dba285caba53f309d6060fca911b43d63f41697
tree419e5390eba9bac1114b722791797fe807182c2a
parentde66b37a174f979cb1c7e9ba15e87f181cb5ad32
PCI: rockchip-ep: Remove wrong mask on subsys_vendor_id

Remove wrong mask on subsys_vendor_id. Both the Vendor ID and Subsystem
Vendor ID are u16 variables and are written to a u32 register of the
controller. The Subsystem Vendor ID was always 0 because the u16 value
was masked incorrectly with GENMASK(31,16) resulting in all lower 16
bits being set to 0 prior to the shift.

Remove both masks as they are unnecessary and set the register correctly
i.e., the lower 16-bits are the Vendor ID and the upper 16-bits are the
Subsystem Vendor ID.

This is documented in the RK3399 TRM section 17.6.7.1.17

[kwilczynski: removed unnecesary newline]
Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller")
Link: https://lore.kernel.org/linux-pci/20240403144508.489835-1-rick.wertenbroek@gmail.com
Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
Signed-off-by: Krzysztof WilczyƄski <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Cc: stable@vger.kernel.org
drivers/pci/controller/pcie-rockchip-ep.c