Bluetooth: af_bluetooth: Fix Use-After-Free in bt_sock_recvmsg
authorHyunwoo Kim <v4bel@theori.io>
Sat, 9 Dec 2023 10:55:18 +0000 (05:55 -0500)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 15 Dec 2023 16:54:18 +0000 (11:54 -0500)
commit2e07e8348ea454615e268222ae3fc240421be768
tree2f11a56621670d5286765251725e03531e5fce08
parent04a342cc49a8522e99c9b3346371c329d841dcd2
Bluetooth: af_bluetooth: Fix Use-After-Free in bt_sock_recvmsg

This can cause a race with bt_sock_ioctl() because
bt_sock_recvmsg() gets the skb from sk->sk_receive_queue
and then frees it without holding lock_sock.
A use-after-free for a skb occurs with the following flow.
```
bt_sock_recvmsg() -> skb_recv_datagram() -> skb_free_datagram()
bt_sock_ioctl() -> skb_peek()
```
Add lock_sock to bt_sock_recvmsg() to fix this issue.

Cc: stable@vger.kernel.org
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/af_bluetooth.c