firmware: qcom: scm: Fix __scm and waitq completion variable initialization
authorMukesh Ojha <quic_mojha@quicinc.com>
Thu, 21 Mar 2024 15:24:02 +0000 (20:54 +0530)
committerBjorn Andersson <andersson@kernel.org>
Sun, 21 Apr 2024 17:08:06 +0000 (12:08 -0500)
commit2e4955167ec5c04534cebea9e8273a907e7a75e1
tree6cfef42d27b7b60ac8a2ffba781aedd28ee2b0a3
parent398a4c58f3f29ac3ff4d777dc91fe40a07bbca8c
firmware: qcom: scm: Fix __scm and waitq completion variable initialization

It is possible qcom_scm_is_available() gives wrong indication that
if __scm is initialized while __scm->dev is not and similar issue
is also possible with __scm->waitq_comp.

Fix this appropriately by the use of release barrier and read barrier
that will make sure if __scm is initialized so, is all of its field
variable.

Fixes: d0f6fa7ba2d6 ("firmware: qcom: scm: Convert SCM to platform driver")
Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic")
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
Link: https://lore.kernel.org/r/1711034642-22860-4-git-send-email-quic_mojha@quicinc.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/firmware/qcom/qcom_scm.c