NFSD: fix LISTXATTRS returning a short list with eof=TRUE
authorJorge Mora <jmora1300@gmail.com>
Thu, 25 Jan 2024 14:45:28 +0000 (07:45 -0700)
committerChuck Lever <chuck.lever@oracle.com>
Fri, 1 Mar 2024 14:12:07 +0000 (09:12 -0500)
commit2f73f37d66774587a0d5053e365736e10fc98c41
tree0e99a3f1d882b773d6ea787cbc32813838fa2fd3
parent61ab5e07587554d0edec318b6c99b7083967b2ec
NFSD: fix LISTXATTRS returning a short list with eof=TRUE

If the XDR buffer is not large enough to fit all attributes
and the remaining bytes left in the XDR buffer (xdrleft) is
equal to the number of bytes for the current attribute, then
the loop will prematurely exit without setting eof to FALSE.
Also in this case, adding the eof flag to the buffer will
make the reply 4 bytes larger than lsxa_maxcount.

Need to check if there are enough bytes to fit not only the
next attribute name but also the eof as well.

Fixes: 23e50fe3a5e6 ("nfsd: implement the xattr functions and en/decode logic")
Signed-off-by: Jorge Mora <mora@netapp.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c