phy: rockchip-inno-usb2: Split ID interrupt phy registers
authorAlex Bee <knaerzche@gmail.com>
Sun, 19 Nov 2023 12:13:36 +0000 (13:13 +0100)
committerVinod Koul <vkoul@kernel.org>
Mon, 27 Nov 2023 13:06:29 +0000 (18:36 +0530)
commit2fda59099462ee700e424ba3ac928d13ad6389a8
treed405f55d194b0266fd38391c974c59974d411c28
parentfa50920b4f82993941e0aac349eb8081ce11e38f
phy: rockchip-inno-usb2: Split ID interrupt phy registers

Commit 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ") added ID
detection interrupt registers. However the current implementation assumes
that falling and rising edge interrupt are always enabled in registers
spanning over subsequent bits.
That is not the case for RK3128's version of the phy and this
implementation can't be used as-is, since there are bits with different
purpose in between.

This splits up the register definitions for id_det_en, id_det_en and
id_det_clr registers in rising and falling edge variants.
It's required as preparation to support RK3128's Innosilicon usb2 phy as
well in this driver and matches pretty much to what the vendor does, so I'm
not expecting issues for other SoCs with that change.

Signed-off-by: Alex Bee <knaerzche@gmail.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20231119121340.109025-2-knaerzche@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-inno-usb2.c