NFS: avoid infinite loop in pnfs_update_layout.
authorNeilBrown <neilb@suse.de>
Wed, 28 Feb 2024 00:24:53 +0000 (11:24 +1100)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Sat, 9 Mar 2024 14:14:51 +0000 (09:14 -0500)
commit2fdbc20036acda9e5694db74a032d3c605323005
tree8dc77e3e36b3cefb0c8ab3d1701d827ebd3a5eb8
parent0b81371d3c6b849bfde9f478bfe70661759cc018
NFS: avoid infinite loop in pnfs_update_layout.

If pnfsd_update_layout() is called on a file for which recovery has
failed it will enter a tight infinite loop.

NFS_LAYOUT_INVALID_STID will be set, nfs4_select_rw_stateid() will
return -EIO, and nfs4_schedule_stateid_recovery() will do nothing, so
nfs4_client_recover_expired_lease() will not wait.  So the code will
loop indefinitely.

Break the loop by testing the validity of the open stateid at the top of
the loop.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/pnfs.c