i3c/master/mipi-i3c-hci: Prefer kcalloc over open coded arithmetic
authorLen Baker <len.baker@gmx.com>
Sun, 12 Sep 2021 15:51:35 +0000 (17:51 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 10 Dec 2021 14:54:46 +0000 (15:54 +0100)
commit313ece22600bcda85aa654af42628385abff215f
tree7dce1e843e6ff7d7de76dc8abf635765f2a89a9b
parentf96b2e77f6d1b0c5181e0eae3dc60a00a5cd692a
i3c/master/mipi-i3c-hci: Prefer kcalloc over open coded arithmetic

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Acked-by: Nicolas Pitre <npitre@baylibre.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20210912155135.7541-1-len.baker@gmx.com
drivers/i3c/master/mipi-i3c-hci/hci.h