um: Refactor deprecated strncpy to memcpy
authorJustin Stitt <justinstitt@google.com>
Wed, 9 Aug 2023 18:19:32 +0000 (18:19 +0000)
committerRichard Weinberger <richard@nod.at>
Sat, 26 Aug 2023 20:48:38 +0000 (22:48 +0200)
commit32280e83b555d692e8c7b96563b0ee2037585712
treee1523b18bad4a62b1e12157e6391ac0911e25f8c
parentab7ca2eb63a2168619f7595622fe29967ed0959b
um: Refactor deprecated strncpy to memcpy

Use `memcpy` since `console_buf` is not expected to be NUL-terminated
and it more accurately describes what is happening with the buffers
`console_buf` and `string` as per Kees' analysis [1].

Also mark char buffer as `__nonstring` as per Kees' suggestion [2].

This change now makes it more clear what this code does and that
`console_buf` is not expected to be NUL-terminated.

Link: https://lore.kernel.org/all/202308081708.D5ADC80F@keescook/
Link: https://github.com/KSPP/linux/issues/90
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Cc: linux-hardening@vger.kernel.org
Suggested-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/drivers/mconsole_kern.c