powerpc/64s: Fix get_hugepd_cache_index() build failure
authorMichael Ellerman <mpe@ellerman.id.au>
Wed, 6 Mar 2024 12:58:51 +0000 (23:58 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 7 Mar 2024 12:06:19 +0000 (23:06 +1100)
commit329105ce53437ff64b29f6c429dfe5dc2aa7b676
tree4733a9f585b2ae67a93f7f8b1bf70b5aee6c5e98
parent5b9e00a6004cf837c43fdb8d5290df619de78024
powerpc/64s: Fix get_hugepd_cache_index() build failure

With CONFIG_BUG=n, the 64-bit Book3S build fails with:

  arch/powerpc/include/asm/book3s/64/pgtable-64k.h: In function 'get_hugepd_cache_index':
  arch/powerpc/include/asm/book3s/64/pgtable-64k.h:51:1: error: no return statement in function returning non-void

Currently the body of the function is just BUG(), so when CONFIG_BUG=n
it is an empty function, leading to the error.

get_hugepd_cache_index() should never be called, the only call is behind
an is_hugepd() check, which is always false for this configuration.

Instead mark it as always inline, and change the BUG() to BUILD_BUG().
That should allow the compiler to see that the function is never called,
and therefore that it never returns, fixing the build error.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240306125853.3714578-1-mpe@ellerman.id.au
arch/powerpc/include/asm/book3s/64/pgtable-64k.h