net: tls: fix use-after-free with partial reads and async decrypt
authorSabrina Dubroca <sd@queasysnail.net>
Wed, 7 Feb 2024 01:18:22 +0000 (17:18 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 10 Feb 2024 21:38:19 +0000 (21:38 +0000)
commit32b55c5ff9103b8508c1e04bfa5a08c64e7a925f
treef15862fc76572e54089b2da8572cb5fc75a40375
parent8590541473188741055d27b955db0777569438e3
net: tls: fix use-after-free with partial reads and async decrypt

tls_decrypt_sg doesn't take a reference on the pages from clear_skb,
so the put_page() in tls_decrypt_done releases them, and we trigger
a use-after-free in process_rx_list when we try to read from the
partially-read skb.

Fixes: fd31f3996af2 ("tls: rx: decrypt into a fresh skb")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tls/tls_sw.c