bpf: remove check in __cgroup_bpf_run_filter_skb
authorOliver Crumrine <ozlinuxc@gmail.com>
Fri, 9 Feb 2024 19:41:22 +0000 (14:41 -0500)
committerMartin KaFai Lau <martin.lau@kernel.org>
Tue, 13 Feb 2024 23:41:17 +0000 (15:41 -0800)
commit32e18e7688c6847b0c9db073aafb00639ecf576c
treedd578e3b4d1a6678286ee3b1f1fcbc70b60c411d
parent2c21a0f67c8ce334b8a58332e8c2d71694bef0ab
bpf: remove check in __cgroup_bpf_run_filter_skb

Originally, this patch removed a redundant check in
BPF_CGROUP_RUN_PROG_INET_EGRESS, as the check was already being done in
the function it called, __cgroup_bpf_run_filter_skb. For v2, it was
reccomended that I remove the check from __cgroup_bpf_run_filter_skb,
and add the checks to the other macro that calls that function,
BPF_CGROUP_RUN_PROG_INET_INGRESS.

To sum it up, checking that the socket exists and that it is a full
socket is now part of both macros BPF_CGROUP_RUN_PROG_INET_EGRESS and
BPF_CGROUP_RUN_PROG_INET_INGRESS, and it is no longer part of the
function they call, __cgroup_bpf_run_filter_skb.

v3->v4: Fixed weird merge conflict.
v2->v3: Sent to bpf-next instead of generic patch
v1->v2: Addressed feedback about where check should be removed.

Signed-off-by: Oliver Crumrine <ozlinuxc@gmail.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/r/7lv62yiyvmj5a7eozv2iznglpkydkdfancgmbhiptrgvgan5sy@3fl3onchgdz3
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
include/linux/bpf-cgroup.h
kernel/bpf/cgroup.c