firmware: qcom_scm: use 64-bit calling convention only when client is 64-bit
authorKathiravan Thirumoorthy <quic_kathirav@quicinc.com>
Mon, 25 Sep 2023 08:29:22 +0000 (13:59 +0530)
committerBjorn Andersson <andersson@kernel.org>
Wed, 27 Sep 2023 23:19:14 +0000 (16:19 -0700)
commit3337a6fea25370d3d244ec6bb38c71ee86fcf837
tree0961e438a1cf83687755a0865b379ca3e031c715
parentf1a1bc8775b26345aba2be278118999e7f661d3d
firmware: qcom_scm: use 64-bit calling convention only when client is 64-bit

Per the "SMC calling convention specification", the 64-bit calling
convention can only be used when the client is 64-bit. Whereas the
32-bit calling convention can be used by either a 32-bit or a 64-bit
client.

Currently during SCM probe, irrespective of the client, 64-bit calling
convention is made, which is incorrect and may lead to the undefined
behaviour when the client is 32-bit. Let's fix it.

Cc: stable@vger.kernel.org
Fixes: 9a434cee773a ("firmware: qcom_scm: Dynamically support SMCCC and legacy conventions")
Reviewed-By: Elliot Berman <quic_eberman@quicinc.com>
Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
Link: https://lore.kernel.org/r/20230925-scm-v3-1-8790dff6a749@quicinc.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/firmware/qcom_scm.c