Avoid hw_desc array overrun in dw-axi-dmac
authorJoao Pinto <Joao.Pinto@synopsys.com>
Wed, 27 Mar 2024 10:49:24 +0000 (10:49 +0000)
committerVinod Koul <vkoul@kernel.org>
Sun, 7 Apr 2024 11:45:24 +0000 (17:15 +0530)
commit333e11bf47fa8d477db90e2900b1ed3c9ae9b697
tree31903f2700baa9280161210e797c767781b1a67e
parent559a6690187ee0ab7875f7c560d3d19e35423fb3
Avoid hw_desc array overrun in dw-axi-dmac

I have a use case where nr_buffers = 3 and in which each descriptor is composed by 3
segments, resulting in the DMA channel descs_allocated to be 9. Since axi_desc_put()
handles the hw_desc considering the descs_allocated, this scenario would result in a
kernel panic (hw_desc array will be overrun).

To fix this, the proposal is to add a new member to the axi_dma_desc structure,
where we keep the number of allocated hw_descs (axi_desc_alloc()) and use it in
axi_desc_put() to handle the hw_desc array correctly.

Additionally I propose to remove the axi_chan_start_first_queued() call after completing
the transfer, since it was identified that unbalance can occur (started descriptors can
be interrupted and transfer ignored due to DMA channel not being enabled).

Signed-off-by: Joao Pinto <jpinto@synopsys.com>
Link: https://lore.kernel.org/r/1711536564-12919-1-git-send-email-jpinto@synopsys.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
drivers/dma/dw-axi-dmac/dw-axi-dmac.h