xfs: remove need_start_rec parameter from xlog_write()
authorDave Chinner <dchinner@redhat.com>
Fri, 18 Jun 2021 15:21:50 +0000 (08:21 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Mon, 21 Jun 2021 17:06:03 +0000 (10:06 -0700)
commit3468bb1ca6e8840789e13c7b9d8b0c556b4fbe79
treeac5b5128111b59ee7abc6ccd9041cfd87094dd3b
parentbad77c375e8de6c776c848e443f7dc2d0d909be5
xfs: remove need_start_rec parameter from xlog_write()

The CIL push is the only call to xlog_write that sets this variable
to true. The other callers don't need a start rec, and they tell
xlog_write what to do by passing the type of ophdr they need written
in the flags field. The need_start_rec parameter essentially tells
xlog_write to to write an extra ophdr with a XLOG_START_TRANS type,
so get rid of the variable to do this and pass XLOG_START_TRANS as
the flag value into xlog_write() from the CIL push.

$ size fs/xfs/xfs_log.o*
  text    data     bss     dec     hex filename
 27595     560       8   28163    6e03 fs/xfs/xfs_log.o.orig
 27454     560       8   28022    6d76 fs/xfs/xfs_log.o.patched

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/xfs/xfs_log.c
fs/xfs/xfs_log_cil.c
fs/xfs/xfs_log_priv.h