mm, slab: ignore hardened usercopy parameters when disabled
authorVlastimil Babka <vbabka@suse.cz>
Wed, 16 Nov 2022 14:56:32 +0000 (15:56 +0100)
committerVlastimil Babka <vbabka@suse.cz>
Sun, 27 Nov 2022 22:35:04 +0000 (23:35 +0100)
commit346907ceb9d11b9e22677c142b45ff50dd20a66a
treea322488eba1e68b6ade9ea8e6e09a1deb784b99b
parentc18c20f16219516b12a4f2fd29c25e06be97e064
mm, slab: ignore hardened usercopy parameters when disabled

With CONFIG_HARDENED_USERCOPY not enabled, there are no
__check_heap_object() checks happening that would use the struct
kmem_cache useroffset and usersize fields. Yet the fields are still
initialized, preventing merging of otherwise compatible caches.

Also the fields contribute to struct kmem_cache size unnecessarily when
unused. Thus #ifdef them out completely when CONFIG_HARDENED_USERCOPY is
disabled. In kmem_dump_obj() print object_size instead of usersize, as
that's actually the intention.

In a quick virtme boot test, this has reduced the number of caches in
/proc/slabinfo from 131 to 111.

Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
Reviewed-by: Christoph Lameter <cl@linux.com>
include/linux/slab_def.h
include/linux/slub_def.h
mm/slab.h
mm/slab_common.c
mm/slub.c