selinux: Annotate struct sidtab_str_cache with __counted_by
authorKees Cook <keescook@chromium.org>
Thu, 17 Aug 2023 20:22:17 +0000 (13:22 -0700)
committerPaul Moore <paul@paul-moore.com>
Tue, 12 Sep 2023 20:58:40 +0000 (16:58 -0400)
commit34df25517a9bbec3436ab6f53074bcce9dc3eafc
treee22c444e46fe5fb2b8694abf6e21126199677fbc
parent0bb80ecc33a8fb5a682236443c1e740d5c917d1d
selinux: Annotate struct sidtab_str_cache with __counted_by

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct sidtab_str_cache.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Paul Moore <paul@paul-moore.com>
Cc: Stephen Smalley <stephen.smalley.work@gmail.com>
Cc: Eric Paris <eparis@parisplace.org>
Cc: Ondrej Mosnacek <omosnace@redhat.com>
Cc: selinux@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/ss/sidtab.c