sunvnet: Use kmap_local_page() instead of kmap_atomic()
authorAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Wed, 23 Nov 2022 20:52:18 +0000 (12:52 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 25 Nov 2022 10:44:01 +0000 (10:44 +0000)
commit350d351389e9f3885697de477986f1f891f95fda
tree6f914c2ea2c122f7edeee09c29f8c0ecd4bdb4e1
parente3128591b55a009558cfb5e1df99b719eb60ce62
sunvnet: Use kmap_local_page() instead of kmap_atomic()

kmap_atomic() is being deprecated in favor of kmap_local_page(). Replace
kmap_atomic() and kunmap_atomic() with kmap_local_page() and kunmap_local()
respectively.

Note that kmap_atomic() disables preemption and page-fault processing, but
kmap_local_page() doesn't. When converting uses of kmap_atomic(), one has
to check if the code being executed between the map/unmap implicitly
depends on page-faults and/or preemption being disabled. If yes, then code
to disable page-faults and/or preemption should also be added for
functional correctness. That however doesn't appear to be the case here,
so just kmap_local_page() is used.

Also note that the page being mapped is not allocated by the driver, and so
the driver doesn't know if the page is in normal memory. This is the reason
kmap_local_page() is used as opposed to page_address().

I don't have hardware, so this change has only been compile tested.

Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sun/sunvnet_common.c