ax25: Fix reference count leak issue of net_device
authorDuoming Zhou <duoming@zju.edu.cn>
Thu, 9 May 2024 09:37:02 +0000 (17:37 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 13 May 2024 23:09:38 +0000 (16:09 -0700)
commit36e56b1b002bb26440403053f19f9e1a8bc075b2
tree023eee5e51da1a8265604386d12404705367eac8
parentb505e0319852b08a3a716b64620168eab21f4ced
ax25: Fix reference count leak issue of net_device

There is a reference count leak issue of the object "net_device" in
ax25_dev_device_down(). When the ax25 device is shutting down, the
ax25_dev_device_down() drops the reference count of net_device one
or zero times depending on if we goto unlock_put or not, which will
cause memory leak.

In order to solve the above issue, decrease the reference count of
net_device after dev->ax25_ptr is set to null.

Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/7ce3b23a40d9084657ba1125432f0ecc380cbc80.1715247018.git.duoming@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ax25/ax25_dev.c