hw/acpi: Move QMP command to hw/core/
authorMarkus Armbruster <armbru@redhat.com>
Tue, 7 Feb 2023 07:51:10 +0000 (08:51 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 23 Feb 2023 13:10:17 +0000 (14:10 +0100)
commit36ebc7db796e6ac97b400dc544192e2e36986b03
treebf5ca955c9692b0b38fbbc780c2e9b55c067fa60
parent588c13fcb015896e4d1f7a516d8ce6336e64133b
hw/acpi: Move QMP command to hw/core/

The QERR_ macros are leftovers from the days of "rich" error objects.
We've been trying to reduce their remaining use.

qmp_query_vm_generation_id() in stubs/vmgenid.c is the last user of
QERR_UNSUPPORTED outside qga/.  Unlike the stubs we just dropped, it
is actually reachable, namely when CONFIG_ACPI_VMGENID is off.  It
always fails like

    (qemu) info vm-generation-id
    Error: this feature or command is not currently supported

Turns out the real qmp_query_vm_generation_id() doesn't actually
depend on CONFIG_ACPI_VMGENID, and fails safely when it's off.  Move
it to hw/core/machine-qmp-cmds.c, and drop the stub.  The error
message becomes

    Error: VM Generation ID device not found

Feels like an improvement to me.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230207075115.1525-8-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
MAINTAINERS
hw/acpi/vmgenid.c
hw/core/machine-qmp-cmds.c
stubs/meson.build
stubs/vmgenid.c [deleted file]