scsi: alua: Move a scsi_device_put() call out of alua_rtpg_select_sdev()
authorBart Van Assche <bvanassche@acm.org>
Mon, 31 Oct 2022 22:47:26 +0000 (15:47 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 8 Nov 2022 03:34:39 +0000 (03:34 +0000)
commit379e2554e3d10e87c0c0a728ef538f3c26d82a98
tree0f52232bd41ed12cfe58e55f2d0bebaf9dd431ec
parent0b25e17e9018a0ea68a9f0b4787672e8c68fa8d5
scsi: alua: Move a scsi_device_put() call out of alua_rtpg_select_sdev()

Move a scsi_device_put() call from alua_rtpg_select_sdev() to its
callers. Fixes the following smatch complaint:

drivers/scsi/device_handler/scsi_dh_alua.c:853 alua_rtpg_select_sdev() warn: sleeping in atomic context

alua_rtpg_work() <- disables preempt
-> alua_rtpg_select_sdev()
   -> scsi_device_put()

Cc: Hannes Reinecke <hare@suse.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20221031224728.2607760-3-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/device_handler/scsi_dh_alua.c