ath11k: fix potential wmi_mgmt_tx_queue race condition
authorMiaoqing Pan <miaoqing@codeaurora.org>
Thu, 18 Feb 2021 06:45:09 +0000 (14:45 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 24 Feb 2021 06:53:08 +0000 (08:53 +0200)
commit3808a18043a8d16ea1bc0ebe59c864f73413dbbf
treecd83d6ec6e7337a95d9f7459da65cdcdc0440abf
parent097e9f0714555e5da72c7ebc5377107fdf10e57d
ath11k: fix potential wmi_mgmt_tx_queue race condition

There is a potential race condition between skb_queue_len()
and skb_queue_tail(), the former may get old value before
updated by the latter.

So use skb_queue_len_lockless() instead. And also use '>=',
in case we queue a few SKBs simultaneously.

Found while discussing a similar fix for ath10k:
https://patchwork.kernel.org/project/linux-wireless/patch/1608515579-1066-1-git-send-email-miaoqing@codeaurora.org/

No functional changes, compile tested only.

Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1613630709-704-1-git-send-email-miaoqing@codeaurora.org
drivers/net/wireless/ath/ath11k/mac.c