tpl/collections: Log an error on unsupported types in IsSet
authorCameron Moore <moorereason@gmail.com>
Thu, 18 May 2017 02:29:35 +0000 (21:29 -0500)
committerBjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Thu, 18 May 2017 18:54:42 +0000 (21:54 +0300)
commit38661c17bb8c31c9f31ee18f8eba5e3bfddd5574
treec5a2275b82cbc85b52ec9565464a272ad5c49dc4
parent42fbded1055d0f49d8c00cf7344edf2017b08ac9
tpl/collections: Log an error on unsupported types in IsSet

Unsupported types are currently silently ignored by IsSet.  An earlier
attempt was made to solve the issue by returning an error.  That attempt
was reverted since it broke some existing themes.

So instead, we'll log an error.  Hopefully, people will stop using IsSet
in this way, and we can eventually return an error outright.

Updates #3092
tpl/collections/collections.go
tpl/collections/collections_test.go