coresight: tmc: Convert to platform remove callback returning void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 23 Apr 2024 08:07:01 +0000 (10:07 +0200)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Thu, 25 Apr 2024 09:07:16 +0000 (10:07 +0100)
commit38a38da447579f683114edb1c8254491b4176853
tree502c662127a89d3630958052af26d4448f573ae6
parent981d5f92ca2e33d1b0ba3e3563de52dc9661fb92
coresight: tmc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Fixes: 70750e257aab ("coresight: tmc: Move ACPI support from AMBA driver to platform driver")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/3cf26d85a8d45f0efb07e07f3307a1b435ebf61e.1713858615.git.u.kleine-koenig@pengutronix.de
drivers/hwtracing/coresight/coresight-tmc-core.c