soundwire: intel_ace2x: fix AC timing setting for ACE2.x
authorChao Song <chao.song@linux.intel.com>
Mon, 27 Nov 2023 12:47:35 +0000 (20:47 +0800)
committerVinod Koul <vkoul@kernel.org>
Tue, 28 Nov 2023 09:57:27 +0000 (15:27 +0530)
commit393cae5f32d640b9798903702018a48c7a45e59f
tree75aecd09e8369ca6a6cd8b270708a1c1cf4900c8
parente199bf52ffda8f98f129728d57244a9cd9ad5623
soundwire: intel_ace2x: fix AC timing setting for ACE2.x

Start from ACE1.x, DOAISE is added to AC timing control
register bit 5, it combines with DOAIS to get effective
timing, and has the default value 1.

The current code fills DOAIS, DACTQE and DODS bits to a
variable initialized to zero, and updates the variable
to AC timing control register. With this operation, We
change DOAISE to 0, and force a much more aggressive
timing. The timing is even unable to form a working
waveform on SDA pin.

This patch uses read-modify-write operation for the AC
timing control register access, thus makes sure those
bits not supposed and intended to change are not touched.

Signed-off-by: Chao Song <chao.song@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20231127124735.2080562-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/intel_ace2x.c