random: don't let 644 read-only sysctls be written to
authorJason A. Donenfeld <Jason@zx2c4.com>
Mon, 28 Feb 2022 13:00:52 +0000 (14:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 May 2022 07:29:10 +0000 (09:29 +0200)
commit39c9e5566ac590ad2c9e488baaf6058c251b8fb5
tree4e24e3b1c40b624415a6abccd5f995565373b564
parente4e1600a674fc5b4fabaa578d8854db96fcc28dd
random: don't let 644 read-only sysctls be written to

commit 77553cf8f44863b31da242cf24671d76ddb61597 upstream.

We leave around these old sysctls for compatibility, and we keep them
"writable" for compatibility, but even after writing, we should keep
reporting the same value. This is consistent with how userspaces tend to
use sysctl_random_write_wakeup_bits, writing to it, and then later
reading from it and using the value.

Cc: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/random.c