mm: optimize CONFIG_PER_VMA_LOCK member placement in vm_area_struct
authorDavid Hildenbrand <david@redhat.com>
Wed, 27 Mar 2024 14:35:48 +0000 (15:35 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 26 Apr 2024 03:56:24 +0000 (20:56 -0700)
commit3b612c8f069fecb84af277c8b90e14832749ceca
tree00c320ef0457162742cf802289fc5c267b1a379f
parent07db63a2161a66a2198bc20c7580dd95af887ff4
mm: optimize CONFIG_PER_VMA_LOCK member placement in vm_area_struct

Currently, we end up wasting some memory in each vm_area_struct. Pahole
states that:
[...]
int                        vm_lock_seq;          /*    40     4 */

/* XXX 4 bytes hole, try to pack */

struct vma_lock *          vm_lock;              /*    48     8 */
bool                       detached;             /*    56     1 */

/* XXX 7 bytes hole, try to pack */
[...]

Let's reduce the holes and memory wastage by moving the bool:
[...]
bool                       detached;             /*    40     1 */

/* XXX 3 bytes hole, try to pack */

int                        vm_lock_seq;          /*    44     4 */
struct vma_lock *          vm_lock;              /*    48     8 */
[...]

Effectively shrinking the vm_area_struct with CONFIG_PER_VMA_LOCK by
8 byte.

Likely, we could place "detached" in the lowest bit of vm_lock, but at
least on 64bit that won't really make a difference, so keep it simple.

Link: https://lkml.kernel.org/r/20240327143548.744070-1-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/mm_types.h