f2fs: don't set RO when shutting down f2fs
authorJaegeuk Kim <jaegeuk@kernel.org>
Wed, 3 Apr 2024 23:07:53 +0000 (23:07 +0000)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 12 Apr 2024 20:58:35 +0000 (20:58 +0000)
commit3bdb7f161697e2d5123b89fe1778ef17a44858e7
tree5390b9fd1cf4617a8e0a1bf707826df54933bd07
parente07230da0500e0919a765037c5e81583b519be2c
f2fs: don't set RO when shutting down f2fs

Shutdown does not check the error of thaw_super due to readonly, which
causes a deadlock like below.

f2fs_ioc_shutdown(F2FS_GOING_DOWN_FULLSYNC)        issue_discard_thread
 - bdev_freeze
  - freeze_super
 - f2fs_stop_checkpoint()
  - f2fs_handle_critical_error                     - sb_start_write
    - set RO                                         - waiting
 - bdev_thaw
  - thaw_super_locked
    - return -EINVAL, if sb_rdonly()
 - f2fs_stop_discard_thread
  -> wait for kthread_stop(discard_thread);

Reported-by: "Light Hsieh (謝明燈)" <Light.Hsieh@mediatek.com>
Reviewed-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/super.c