module/decompress: Never use kunmap() for local un-mappings
authorFabio M. De Francesco <fmdefrancesco@gmail.com>
Wed, 15 Mar 2023 12:52:56 +0000 (13:52 +0100)
committerLuis Chamberlain <mcgrof@kernel.org>
Wed, 22 Mar 2023 23:12:35 +0000 (16:12 -0700)
commit3c17655ab13704582fe25e8ea3200a9b2f8bf20a
treedd95120fe93ea55311fc00a0396d6af72a734d5b
parent3703bd54cd37e7875f51ece8df8c85c184e40bba
module/decompress: Never use kunmap() for local un-mappings

Use kunmap_local() to unmap pages locally mapped with kmap_local_page().

kunmap_local() must be called on the kernel virtual address returned by
kmap_local_page(), differently from how we use kunmap() which instead
expects the mapped page as its argument.

In module_zstd_decompress() we currently map with kmap_local_page() and
unmap with kunmap(). This breaks the code and so it should be fixed.

Cc: Piotr Gorski <piotrgorski@cachyos.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: Ira Weiny <ira.weiny@intel.com>
Fixes: 169a58ad824d ("module/decompress: Support zstd in-kernel decompression")
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Piotr Gorski <piotrgorski@cachyos.org>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
kernel/module/decompress.c